Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update grpc-java version to 1.54.1 and clean up grpc tests #6685

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Update grpc-java version to 1.54.1 and clean up grpc tests #6685

merged 2 commits into from
Apr 25, 2023

Conversation

thegridman
Copy link
Collaborator

This PR is to update grpc-java to the latest version, which depends on a version of Netty closer to the one Helidon now depends on.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 25, 2023
@thegridman thegridman added the 3.x Issues for 3.x version branch label Apr 25, 2023
@barchetta barchetta added dependencies Pull requests that update a dependency file grpc labels Apr 25, 2023
barchetta
barchetta approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@barchetta barchetta merged commit d4352c2 into helidon-io:helidon-3.x Apr 25, 2023
@thegridman thegridman deleted the grpc-tests-3.x branch August 17, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barchetta barchetta barchetta approved these changes

Assignees

@thegridman thegridman

Labels
3.x Issues for 3.x version branch dependencies Pull requests that update a dependency file grpc OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thegridman @barchetta